Piersy/migrate script full alfajores snap sync#186
Closed
jcortejoso wants to merge 9 commits intocelo7from
Closed
Conversation
Improving the docker tagging logic. [Context](https://github.com/orgs/community/discussions/25191) (thanks @alvarof2 for the link)
Using short hast
Fix issue with tags
* Revert to using time.Now() for migration block Instead of simply adding 5 to the parent block time. We really do need a deterministic time for the migration block so that all parties that run the migration arrive at the same migration block but the problem is that op-geth requires that the L2 migration block (aka l2 origin) occurs after the l1 origin (I guess the point where you deploy the bridge contracts to the l1). When we migrate a partially synced datadir the block before the transition block will be very old, up to 4 years old! So of course it occurs before the l1 origin. So a fix just to get things working is to use time.Now(), but probably we should make this a configurable parameter. * add flag to specify timestamp * Update op-chain-ops/cmd/celo-migrate/main.go --------- Co-authored-by: alecps <alec@cLabs.co>
…grate-script-full-alfajores-snap-sync
Member
Author
karlb
pushed a commit
that referenced
this pull request
Aug 30, 2024
* contracts: Add gas input to precompile pre-images (#186) Also update the cannon evm tests to use the new precompile preimage scheme. --------- Co-authored-by: Adrian Sutton <adrian@oplabs.co> * op-challenger: Support uploading data in new format. (#188) * op-program: Add required gas to precompile oracle key (#176) * op-challenger: Support multiple versions of the preimage oracle contract --------- Co-authored-by: Adrian Sutton <adrian@oplabs.co> --------- Co-authored-by: inphi <mlaw2501@gmail.com> --------- Co-authored-by: Adrian Sutton <adrian@oplabs.co>
palango
pushed a commit
that referenced
this pull request
Jan 14, 2025
…#13626) * feat: remove cross l2 inbox execute message (#185) * feat: remove cross l2 inbox execute message * feat: remove cross l2 inbox execute message * feat: remove cross l2 inbox identifier checks (#186) * feat: remove cross l2 inbox identifier checks * fix: clear emit and validate naming * fix: pre pr (#187) --------- Co-authored-by: AgusDuha <81362284+agusduha@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes when L1 migration block is too old, and the migration block generated timestamp was also generated as a too old block and latter sequencer rejected to generate more blocks.